Solution 0x59f521a38d63d78ba9b1888dc4edfb67ead58cb190ddee4122aebdafa9c99758
All checks were successful
elffuss/validation Validation passed with flags for the reviewers

T2T-Item: 0x59f521a38d63d78ba9b1888dc4edfb67ead58cb190ddee4122aebdafa9c99758
T2T-Issue: 0xb39df7f42e2f2a5fe2272fbd62986ee6a0738e02391e5725f8b27a3a20f68b29
This commit is contained in:
2026-10-02 08:56:31 +00:00
committed by elffuss-bot
parent 42a4a9a67c
commit 075545c4ee
3 changed files with 46 additions and 1 deletions

View File

@@ -0,0 +1,18 @@
{
"schema": "elffuss-t2t/criteria@2",
"issue": 8,
"criteria": [
{
"index": 1,
"tests": [
"tests/acceptance/8/criteria.test.js::criterion 1"
]
},
{
"index": 2,
"tests": [
"tests/acceptance/8/criteria.test.js::criterion 2"
]
}
]
}

View File

@@ -0,0 +1,27 @@
import { test } from 'node:test'
import assert from 'node:assert/strict'
import { readFileSync } from 'node:fs'
import * as mod from '../../../web/js/tools/clone.js' // the code under test: call it as mod.<name>(...)
const source = readFileSync(new URL('../../../web/js/tools/clone.js', import.meta.url), 'utf8') // the text of web/js/tools/clone.js, for a criterion about how the file is written
test('criterion 1', () => {
// `parseRepoUrl("https://github.com/o/r.git/")` returns `{ host: "github", owner: "o", repo: "r", branch: null }`, and `parseRepoUrl("https://github.com/o/r/tree/dev")` still returns branch `"dev"`.
const result1 = mod.parseRepoUrl("https://github.com/o/r.git/")
assert.deepStrictEqual(result1, { host: "github", owner: "o", repo: "r", branch: null })
const result2 = mod.parseRepoUrl("https://github.com/o/r/tree/dev")
assert.equal(result2.branch, "dev")
})
test('criterion 2', () => {
// `parseRepoUrl("https://bitbucket.org/o/r.git/")` returns `{ host: "bitbucket", owner: "o", repo: "r", branch: null }`, and `parseRepoUrl("https://example.org/o/r")` still throws an Error.
const result1 = mod.parseRepoUrl("https://bitbucket.org/o/r.git/")
assert.deepStrictEqual(result1, { host: "bitbucket", owner: "o", repo: "r", branch: null })
try {
mod.parseRepoUrl("https://example.org/o/r")
assert.fail("Expected parseRepoUrl to throw an Error for invalid URL")
} catch (e) {
// Expected error
}
})

View File

@@ -12,7 +12,7 @@ const MAX_FILE_BYTES = 4 * 1024 * 1024; // ficheros más grandes se saltan (bina
const CONCURRENCY = 10; const CONCURRENCY = 10;
export function parseRepoUrl(raw) { export function parseRepoUrl(raw) {
const url = String(raw || '').trim().replace(/\.git$/, '').replace(/\/+$/, ''); const url = String(raw || '').trim().replace(/\.git\/?$/, '').replace(/\/+$/, '');
let m = url.match(/^(?:https?:\/\/)?(?:www\.)?github\.com\/([\w.-]+)\/([\w.-]+)(?:\/tree\/([\w./-]+))?/i); let m = url.match(/^(?:https?:\/\/)?(?:www\.)?github\.com\/([\w.-]+)\/([\w.-]+)(?:\/tree\/([\w./-]+))?/i);
if (m) return { host: 'github', owner: m[1], repo: m[2], branch: m[3] || null }; if (m) return { host: 'github', owner: m[1], repo: m[2], branch: m[3] || null };
m = url.match(/^(?:https?:\/\/)?(?:www\.)?bitbucket\.org\/([\w.-]+)\/([\w.-]+)(?:\/src\/([\w./-]+))?/i); m = url.match(/^(?:https?:\/\/)?(?:www\.)?bitbucket\.org\/([\w.-]+)\/([\w.-]+)(?:\/src\/([\w./-]+))?/i);