diff --git a/tests/acceptance/4/CRITERIA.json b/tests/acceptance/4/CRITERIA.json new file mode 100644 index 0000000..002b241 --- /dev/null +++ b/tests/acceptance/4/CRITERIA.json @@ -0,0 +1,30 @@ +{ + "schema": "elffuss-t2t/criteria@2", + "issue": 4, + "criteria": [ + { + "index": 1, + "tests": [ + "tests/acceptance/4/criteria.test.js::criterion 1" + ] + }, + { + "index": 2, + "tests": [ + "tests/acceptance/4/criteria.test.js::criterion 2" + ] + }, + { + "index": 3, + "tests": [ + "tests/acceptance/4/criteria.test.js::criterion 3" + ] + }, + { + "index": 4, + "tests": [ + "tests/acceptance/4/criteria.test.js::criterion 4" + ] + } + ] +} diff --git a/tests/acceptance/4/criteria.test.js b/tests/acceptance/4/criteria.test.js new file mode 100644 index 0000000..66bfa11 --- /dev/null +++ b/tests/acceptance/4/criteria.test.js @@ -0,0 +1,28 @@ +import { test } from 'node:test' +import assert from 'node:assert/strict' +import { readFileSync } from 'node:fs' +import * as mod from '../../../web/js/tools/clone.js' // the code under test: call it as mod.(...) +const source = readFileSync(new URL('../../../web/js/tools/clone.js', import.meta.url), 'utf8') // the text of web/js/tools/clone.js, for a criterion about how the file is written + +test('criterion 1', () => { + // `parseRepoUrl("https://github.com/o/r.git/")` returns `{ host: "github", owner: "o", repo: "r", branch: null }`. + const result = mod.parseRepoUrl("https://github.com/o/r.git/") + assert.deepStrictEqual(result, { host: "github", owner: "o", repo: "r", branch: null }) +}) + +test('criterion 2', () => { + // `parseRepoUrl("github.com/o/r.git")` returns `{ host: "github", owner: "o", repo: "r", branch: null }`. + const result = mod.parseRepoUrl("github.com/o/r.git") + assert.deepStrictEqual(result, { host: "github", owner: "o", repo: "r", branch: null }) +}) + +test('criterion 3', () => { + // `parseRepoUrl("https://github.com/o/r/tree/dev")` returns `{ host: "github", owner: "o", repo: "r", branch: "dev" }`. + const result = mod.parseRepoUrl("https://github.com/o/r/tree/dev") + assert.deepStrictEqual(result, { host: "github", owner: "o", repo: "r", branch: "dev" }) +}) + +test('criterion 4', () => { + // `parseRepoUrl("https://example.org/o/r")` throws an Error. + assert.throws(() => mod.parseRepoUrl("https://example.org/o/r"), Error) +}) diff --git a/web/js/tools/clone.js b/web/js/tools/clone.js index 09ee334..4166d87 100644 --- a/web/js/tools/clone.js +++ b/web/js/tools/clone.js @@ -12,7 +12,7 @@ const MAX_FILE_BYTES = 4 * 1024 * 1024; // ficheros más grandes se saltan (bina const CONCURRENCY = 10; export function parseRepoUrl(raw) { - const url = String(raw || '').trim().replace(/\.git$/, '').replace(/\/+$/, ''); + const url = String(raw || '').trim().replace(/\.git\/?$/, '').replace(/\/+$/, ''); let m = url.match(/^(?:https?:\/\/)?(?:www\.)?github\.com\/([\w.-]+)\/([\w.-]+)(?:\/tree\/([\w./-]+))?/i); if (m) return { host: 'github', owner: m[1], repo: m[2], branch: m[3] || null }; m = url.match(/^(?:https?:\/\/)?(?:www\.)?bitbucket\.org\/([\w.-]+)\/([\w.-]+)(?:\/src\/([\w./-]+))?/i);