From fb8ecc780cdfbceb0258bcb9033d83c2c65d0544 Mon Sep 17 00:00:00 2001 From: elffuss-bot Date: Fri, 2 Oct 2026 08:01:25 +0000 Subject: [PATCH] event 405 proposal --- events/0000000405.json | 1 + 1 file changed, 1 insertion(+) create mode 100644 events/0000000405.json diff --git a/events/0000000405.json b/events/0000000405.json new file mode 100644 index 0000000..3e2a69e --- /dev/null +++ b/events/0000000405.json @@ -0,0 +1 @@ +{"data":{"body":{"criteria":["The `chat` function of core/providers/onnx.js declares a fourth parameter named `signal` with default `null`.","With an aborted `signal`, `chat` never calls `onToken`, and with no `signal` it still calls `onToken` for every token."],"files":["core/providers/onnx.js"],"problem":"The product copy of the ONNX provider takes a fourth argument `signal` and stops calling the token callback once the signal is aborted. The core copy of `chat` in core/providers/onnx.js has only three parameters, so a product that vendors the core loses the stop button for this provider. Why it matters: The core is the source the products vendor from; if it lacks the fix, the next sync removes abort support from the products.","proposal":"Give `chat` a fourth parameter `signal = null` and wrap the pipeline token callback so `onToken` is not called after `signal?.aborted` is true.","title":"Add abort support to the core ONNX provider chat function"},"envelope":{"kind":"identity","signature":"0x4b3602a48eb83ae5f7dfd672c0780f05ed16bdd0b35e8e5e9a3c79484ea2590f650fc9243eab3373bf5bf6db45a3c3df619d89feb94181a20875e59b57e24b621c"},"message":{"author":"0x08809b42d05ae9526f4aa4c9670ce168aac68919","bodyHash":"0xb4c2322213ffbe9b5aa05b5a5f9f2a25371849fe03023f40c5339354aaa54125","dedupHash":"0x46ccc25675e53256dce6a84ca7fdb393d28fccf01464b3e5ecd7556eb95138da","issuedAt":"1790928084","kind":2,"nonce":"9","origin":4,"project":"0x16d6e75341c5f21003a4d9e89b416a545f7335094d7df139fd20942c9b7fb2de","repo":"0xb599aedd619c8321892f96f0446029f00f5a12bf3043c65341bbf5afe98384ed"}},"eventHash":"0x489b747d067b208232e3d6452e8ffd66b47f46cdda964c6e238251f14f4b904f","gatewaySignature":"0x020068ea76bcd500e275f1848971414696206e896eca457dc7b08d8b7e025fd12d6405ddfa794fa0b0817986e4e362da084bd7bbba112a4f90e06732642aa6de1c","prev":"0xd07f11d0abf48c8b822529885b63667448b5cdf12f24380703bb051912822640","seq":405,"ts":1790928085,"type":"proposal","v":2}