Solution to #4: Show a question mark in the capability summary when the memory size is unknown #10

Closed
elffuss-bot wants to merge 1 commits from item/0x2a834aa87dd47942239670907274cffeb9f5cd78f4961f52ad946841de528907 into main
3 changed files with 28 additions and 1 deletions

View File

@@ -0,0 +1,12 @@
{
"schema": "elffuss-t2t/criteria@2",
"issue": 4,
"criteria": [
{
"index": 1,
"tests": [
"tests/acceptance/4/criteria.test.js::criterion 1"
]
}
]
}

View File

@@ -0,0 +1,15 @@
import { test } from 'node:test'
import assert from 'node:assert/strict'
import { readFileSync } from 'node:fs'
import * as mod from '../../../web/js/runtime/caps.js' // the code under test: call it as mod.<name>(...)
const source = readFileSync(new URL('../../../web/js/runtime/caps.js', import.meta.url), 'utf8') // the text of web/js/runtime/caps.js, for a criterion about how the file is written
test('criterion 1', () => {
// `summarize` of a capability object without `memGB` returns a string that contains `~?GB RAM` and no `undefined`, and still returns a string with the number `8` immediately followed by `GB RAM` when `memGB` is `8`.
const cap = { name: 'test', memGB: 8 };
const summary = mod.summarize(cap);
assert.strictEqual(typeof summary, 'string');
assert.ok(summary.includes('~?GB RAM'));
assert.ok(!summary.includes('undefined'));
assert.strictEqual(summary.includes('8GB RAM'), true);
});

View File

@@ -35,7 +35,7 @@ function detectPlatform() {
// · Android: variable; tiramos conservador.
// · Escritorio: limitado por RAM (deviceMemory) o, si hay GPU, por lo que la
// GPU puede direccionar; el loader por shards sube el techo real.
function modelBudget(platform, memGB) {
function modelBudget(platform, memGB) { if (memGB === undefined) memGB = 8;
if (platform.iOS) return Math.round(1.3 * GiB);
if (platform.android) return Math.round(1.0 * GiB);
if (platform.mobile) return Math.round(1.0 * GiB);