Solution to #5: Make parseSkill read SKILL.md files that use Windows line endings in Elffuss Code #9

Closed
elffuss-bot wants to merge 1 commits from item/0x2a7b6a284a867d4e10849050698c3956c5f7840a3bc29190fc7798287e6da0b9 into main
3 changed files with 47 additions and 2 deletions

View File

@@ -0,0 +1,24 @@
{
"schema": "elffuss-t2t/criteria@2",
"issue": 5,
"criteria": [
{
"index": 1,
"tests": [
"tests/acceptance/5/criteria.test.js::criterion 1"
]
},
{
"index": 2,
"tests": [
"tests/acceptance/5/criteria.test.js::criterion 2"
]
},
{
"index": 3,
"tests": [
"tests/acceptance/5/criteria.test.js::criterion 3"
]
}
]
}

View File

@@ -0,0 +1,20 @@
import { test } from 'node:test'
import assert from 'node:assert/strict'
import { readFileSync } from 'node:fs'
import * as mod from '../../../web/js/skills.js' // the code under test: call it as mod.<name>(...)
const source = readFileSync(new URL('../../../web/js/skills.js', import.meta.url), 'utf8') // the text of web/js/skills.js, for a criterion about how the file is written
test('criterion 1', () => {
// `parseSkill("---\r\nname: demo\r\ndescription: x\r\n---\r\nBody")` returns `{ name: "demo", description: "x", content: "Body" }`.
assert.deepEqual(mod.parseSkill("---\r\nname: demo\r\ndescription: x\r\n---\r\nBody"), { name: "demo", description: "x", content: "Body" })
})
test('criterion 2', () => {
// `parseSkill("---\nname: demo\ndescription: x\n---\nBody")` returns `{ name: "demo", description: "x", content: "Body" }`.
assert.deepEqual(mod.parseSkill("---\nname: demo\ndescription: x\n---\nBody"), { name: "demo", description: "x", content: "Body" })
})
test('criterion 3', () => {
// `parseSkill("Body only", "fallback")` returns `{ name: "fallback", description: "", content: "Body only" }`.
assert.deepEqual(mod.parseSkill("Body only", "fallback"), { name: "fallback", description: "", content: "Body only" })
})

View File

@@ -131,11 +131,12 @@ export async function installFromRepo(entry) {
// SKILL.md → { name, description, content }
export function parseSkill(md, fallbackName = 'skill') {
const fm = md.match(/^---\n([\s\S]*?)\n---/);
const normalizedMd = md.replace(/\r\n/g, '\n');
const fm = normalizedMd.match(/^---\n([\s\S]*?)\n---/);
const meta = fm?.[1] || '';
const name = meta.match(/^name:\s*(.+)$/m)?.[1]?.trim() || fallbackName;
const description = (meta.match(/^description:\s*([\s\S]+?)(?:\n\w+:|$)/m)?.[1] || '').replace(/\s+/g, ' ').trim();
const content = md.replace(/^---\n[\s\S]*?\n---\n?/, '').trim();
const content = normalizedMd.replace(/^---\n[\s\S]*?\n---\n?/, '').trim();
return { name, description, content };
}