Solution to #2: Make cosine fail on vectors of different lengths in the copilot diarizer #6

Closed
elffuss-bot wants to merge 1 commits from item/0xa95f32ea03bfe95df656140edb88432fac22efa32917418f73d0f29ce155ecd0 into main
3 changed files with 32 additions and 1 deletions

View File

@@ -25,7 +25,7 @@ export async function loadDiarizer(TF, { device = 'wasm' } = {}) {
return { seg, segP, emb, embP };
}
const cos = (a, b) => { let dt = 0, na = 0, nb = 0; for (let i = 0; i < a.length; i++) { dt += a[i]*b[i]; na += a[i]*a[i]; nb += b[i]*b[i]; } return dt / (Math.sqrt(na)*Math.sqrt(nb) || 1); };
const cos = (a, b) => { if (a.length !== b.length) throw new Error(`cosine: length mismatch (${a.length} vs ${b.length})`); let dt = 0, na = 0, nb = 0; for (let i = 0; i < a.length; i++) { dt += a[i]*b[i]; na += a[i]*a[i]; nb += b[i]*b[i]; } return dt / (Math.sqrt(na)*Math.sqrt(nb) || 1); };
const rms = (a) => { let s = 0; for (const v of a) s += v*v; return Math.sqrt(s/a.length); };
async function embed(D, slice) {

View File

@@ -0,0 +1,18 @@
{
"schema": "elffuss-t2t/criteria@2",
"issue": 2,
"criteria": [
{
"index": 1,
"tests": [
"tests/acceptance/2/criteria.test.js::criterion 1"
]
},
{
"index": 2,
"tests": [
"tests/acceptance/2/criteria.test.js::criterion 2"
]
}
]
}

View File

@@ -0,0 +1,13 @@
import test from 'node:test';
import assert from 'node:assert/strict';
const mod = await import('../../../diarize.mjs');
test('criterion 1', () => {
assert.throws(() => mod.cosine([1, 2, 3], [1, 2]), (err) => err instanceof Error && err.message.startsWith('cosine:'));
assert.equal(mod.cosine([1, 0], [1, 0]), 1);
});
test('criterion 2', () => {
assert.throws(() => mod.cosine([1, 0], [1, 0, 5]), (err) => err instanceof Error && err.message.startsWith('cosine:'));
assert.equal(mod.cosine([0, 0], [0, 0]), 0);
});