elffuss/ledger
1
0
Fork 0
Code Issues Pull Requests Releases Activity

event 401 proposal

Browse Source
This commit is contained in:
elffuss-bot
2026-10-02 08:01:22 +00:00
parent 89bfdbe4b4
commit 6dc12d1bd2
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
events/0000000401.json Normal file
View File

@@ -0,0 +1 @@
{"data":{"body":{"criteria":["`parseRepoUrl(\"https://github.com/o/r.git/\")` returns `{ host: \"github\", owner: \"o\", repo: \"r\", branch: null }`, and `parseRepoUrl(\"https://github.com/o/r/tree/dev\")` still returns branch `\"dev\"`.","`parseRepoUrl(\"https://bitbucket.org/o/r.git/\")` returns `{ host: \"bitbucket\", owner: \"o\", repo: \"r\", branch: null }`, and `parseRepoUrl(\"https://example.org/o/r\")` still throws an Error."],"files":["web/js/tools/clone.js"],"problem":"`parseRepoUrl` in web/js/tools/clone.js strips `.git` and then trailing slashes, in that order. For `https://github.com/o/r.git/` the `.git` is not at the end when it is stripped, so the result has `repo: \"r.git\"` and the clone step asks for a repository that does not exist. Why it matters: People paste clone URLs from many places; one trailing slash should not turn a valid URL into a confusing not-found error.","proposal":"Strip trailing slashes first and then `.git`, and change nothing else.","title":"Let parseRepoUrl accept a repository URL that ends in .git and a slash"},"envelope":{"kind":"identity","signature":"0xf34ab0b2a3175896b32ee1de504d5863184058018d03840408b5f70fe518763e36ae69f4dfd2885501c4ce4f6303182fb01da0aa52a0d67b61002b5f7cc26d951c"},"message":{"author":"0x08809b42d05ae9526f4aa4c9670ce168aac68919","bodyHash":"0x6492a844ecdd9799d895d997d30df62ebc66e02fdcb797afe2730a9c9f9167be","dedupHash":"0x151a7eb4896bef86220fd61863ae16ffde8207ed1c0b32f3f367bc81a9083ddf","issuedAt":"1790928082","kind":1,"nonce":"6","origin":4,"project":"0x16d6e75341c5f21003a4d9e89b416a545f7335094d7df139fd20942c9b7fb2de","repo":"0xd822e541c0173492ca0725a08935bcd8eaa756a9559600a9427d0daac625ead2"}},"eventHash":"0xeb5ff6bbd97d47bda86cfee70a329e6824a08ab7612fcf9a27a808d735d1f862","gatewaySignature":"0x94aba9ba14c23b2942fd69a197467748a1b1ed0fedc084be0f4c82440308ef522d24bc83df948cede0c29a27018426162db187278ed79ae8f5bd52f9e36397c41c","prev":"0xdd21887559d219e177aeeca32a33f0960355ba62105ce5da05defb5654a055e0","seq":401,"ts":1790928082,"type":"proposal","v":2}