Solution to #5: Read SKILL.md files with Windows line endings in Elffuss Claw #9

Closed
elffuss-bot wants to merge 1 commits from item/0x65af3cc273e018f0166c19b9c736380dced2ca4d49b94967b7f3c0bdac06d5b5 into main
3 changed files with 27 additions and 1 deletions

View File

@@ -0,0 +1,12 @@
{
"schema": "elffuss-t2t/criteria@2",
"issue": 5,
"criteria": [
{
"index": 1,
"tests": [
"tests/acceptance/5/criteria.test.js::criterion 1"
]
}
]
}

View File

@@ -0,0 +1,14 @@
import { test } from 'node:test'
import assert from 'node:assert/strict'
import { readFileSync } from 'node:fs'
import * as mod from '../../../web/js/skills.js' // the code under test: call it as mod.<name>(...)
const source = readFileSync(new URL('../../../web/js/skills.js', import.meta.url), 'utf8') // the text of web/js/skills.js, for a criterion about how the file is written
test('criterion 1', () => {
// `parseSkill("---\r\nname: demo\r\ndescription: x\r\n---\r\nBody")` returns `{ name: "demo", description: "x", content: "Body" }`, and still returns `{ name: "fallback", description: "", content: "Body only" }`
const result1 = mod.parseSkill("---\r\nname: demo\r\ndescription: x\r\n---\r\nBody")
assert.deepStrictEqual(result1, { name: "demo", description: "x", content: "Body" })
const result2 = mod.parseSkill("Body only", "fallback")
assert.deepStrictEqual(result2, { name: "fallback", description: "", content: "Body only" })
})

View File

@@ -138,7 +138,7 @@ export function parseSkill(md, fallbackName = 'skill') {
const meta = fm?.[1] || '';
const name = meta.match(/^name:\s*(.+)$/m)?.[1]?.trim() || fallbackName;
const description = (meta.match(/^description:\s*([\s\S]+?)(?:\n\w+:|$)/m)?.[1] || '').replace(/\s+/g, ' ').trim();
const content = md.replace(/^---\n[\s\S]*?\n---\n?/, '').trim();
const content = md.replace(/^---\r?\n[\s\S]*?\r?\n---\r?\n?/, '').trim();
return { name, description, content };
}